Fix UnitarySynthesis
for 3+ qubits when compiled for a backend
#13591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When encountering a 3+ qubit
UnitaryGate
,UnitarySynthesis
currently replaces the whole dag with the definition of the block instead of appending it, seeqiskit/crates/accelerate/src/unitary_synthesis.rs
Line 375 in 079f69f
Details and comments
This also leads to #13586 because the qubit/clbit interners are overwritten, but maybe more importantly this can lead to issues when multiple 3-qubit blocks are present in the circuit. E.g. running
produces an empty circuit, since the last block implements the identity.
Some additional tests, such as the precise case of #13586 and a series of 3q
UnitaryGate
s, should be added.